CLDR-5854 Add-examples-for-relative-dates-and-times #4060
Conversation
haytenf
force-pushed
the
CLDR-5854-Add-examples-for-relative-dates-and-times
branch
from
9b46296 to
09276e0
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
haytenf
changed the title
|
@macchiati @srl295 @btangmu Hello! I've made a new PR for this ticket since the old one was (accidentally) trying to merge to the wrong branch. The main thing I wanted to address is that the casing/context side isn't covered by this implementation for two main reasons (the examples for Romanian in the markdown table show this):
In terms of just getting examples in for the relative items, however, it may still be useful. |
| @@ -326,6 +326,19 @@ public void setCachingEnabled(boolean enabled) { | |||
| } | |||
| }; | |||
|
|
|||
| // map relativeTimePattern counts to numeric examples | |||
There was a problem hiding this comment.
We might need to make this map dependent on locale. That can be done under CLDR-18025 "Further work on examples for relative dates and times".
| String skeleton; | ||
| String type = parts.findAttributeValue("field", "type"); | ||
| if (type.startsWith("hour")) { | ||
| skeleton = "Hm"; |
There was a problem hiding this comment.
We might want to make this "jm" or "Cm" to use hour cycle prefs based on locale. That can be done under CLDR-18025 "Further work on examples for relative dates and times".
There was a problem hiding this comment.
Actually this is being used directly as a key to look up the availableFormats pattern, so mapping of meta characters like 'j' and 'C' will not work
| SimpleDateFormat sdf = icuServiceBuilder.getDateFormat("gregorian", dateFormat); | ||
| String sampleDate = sdf.format(DATE_SAMPLE); | ||
| String example1 = | ||
| value.substring(0, 1).toUpperCase() + value.substring(1) + " (" + sampleDate + ")"; |
There was a problem hiding this comment.
Hmm. We need to use locale-sensitive Titlecasing (not just toUpperCase the first char), and we also only want to do this if the contextTransforms data says that relative fields should be title-cased in a stand-alone context. Again, I will fix this in CLDR-18025 "Further work on examples for relative dates and times".
CLDR-5854
ALLOW_MANY_COMMITS=true